[PATCH] passdb: handle UPN in lookup_name correctly
Andreas Schneider
asn at samba.org
Mon Feb 11 15:07:45 UTC 2019
On Monday, February 11, 2019 10:41:06 AM CET Ralph Wuerthner via samba-
technical wrote:
> Hi List!
Hi Ralph,
> Please see attached patchset:
> The fix for Samba bugzilla 13312 (commit 1775ac8aa4) caused a regression
> when looking up names in UPN notation: Because winbind_lookup_name is
> called with lp_workgroup as domain name the lookup is now failing and
> the SID for an unmapped Unix user is returned by lookup_name. Fixed by
> calling winbind_lookup_name with an empty domain name in case the name
> is in UPN notation.
>
> The patchset already passed a CI run:
> https://gitlab.com/samba-team/devel/samba/pipelines/46689980
Thanks for your contribution!
Please use DGB_DEBUG() instead of DEBUG(10, ...)
In lookup_upn() use a helper variable 'bool ok'. And check talloc_strdup() for
NULL.
Andreas
--
Andreas Schneider asn at samba.org
Samba Team www.samba.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
More information about the samba-technical
mailing list