[PATCH] fix sambaundoguidindex

[Björn JACKE]

can I get a 2nd revewer for this fix please?

This bug can prevent people to go back to a non-guid index samba version. Along
with https://bugzilla.samba.org/show_bug.cgi?id=13760 (update to 4.9 without
going via a 4.8 release is broken) this is a bit nasty as users might get stuck
with a non-downgradable database and a broken 4.9 samba setup.

Also, does someone have an idea about the root cause of
https://bugzilla.samba.org/show_bug.cgi?id=13760
This bug will badly hit ad-dc users of those distributions which skip the 4.8
release.

Thanks
Björn

On 2019-01-23 at 14:13 +0100 Björn JACKE via samba-technical sent off:
> Hi,
> 
> please review and push eventually...
> 
> Björn
> 

> From fa0a17f4e94691ba5820dd99254d98cc52d562f9 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= <bj at sernet.de>
> Date: Wed, 23 Jan 2019 14:01:26 +0100
> Subject: [PATCH] sambaundoguididx: use the right escaped or unescaped sam
>  ldb files
> 
> the correct filename is taken from the partition database before, we should not
> unescape that because this can result in a new unescaped ldb file being created
> and the script not to work at all.
> 
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13759
> 
> Signed-off-by: Bjoern Jacke <bjacke at samba.org>
> ---
>  source4/scripting/bin/sambaundoguididx | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/source4/scripting/bin/sambaundoguididx b/source4/scripting/bin/sambaundoguididx
> index 008e79805fff..20a84c34618e 100755
> --- a/source4/scripting/bin/sambaundoguididx
> +++ b/source4/scripting/bin/sambaundoguididx
> @@ -57,8 +57,7 @@ privatedir = os.path.dirname(url)
>  
>  dbs = []
>  for part in partitions[0]['partition']:
> -    file_quoted = part.split(":")[1]
> -    tdbname = urllib.unquote(file_quoted)
> +    tdbname = part.split(":")[1]
>      tdbpath = os.path.join(privatedir, tdbname)
>  
>      db = ldb.Ldb(url=tdbpath, options=["modules:"])
> -- 
> 2.17.1
> 


-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: 0551-370000-0, mail: kontakt at sernet.de
Gesch.F.: Dr. Johannes Loxen & Reinhild Jung
AG Göttingen: HR-B 2816 - https://www.sernet.de