[WIP PATCH] DCE/RPC server merge (was: Re: [WIP PATCH] Witness Server with CTDB integration)

Andreas Schneider asn at samba.org
Fri Feb 8 19:07:57 UTC 2019


On Friday, February 8, 2019 6:41:39 PM CET Samuel Cabrero wrote:
> > Could you please push this somewhere for inspection? I'm sure metze
> > wants to
> > take a look too :-)
> 
> Of course, feedback will be really welcomed.
> 
> I have been cleaning up what I have so far, there are three branches:
> 
> * https://gitlab.com/scabrero/samba/tree/dcerpc-server-merge-s3-prep-v2
> - This is preparation for S3
> - Rename functions to make the merge easier
> - Remove the named_pipe_client struct to make use of general ncacn_conn
> - Add the posibility to attach private data to sockets in prefork
> "process model", used later to associate the socket with the
> dcesrv_endpoint.

I've just reviewed this branch and had a few comments. However this already 
looks quite good. Let me know if something is unclear.

Will look at the others next week.


Have a nice weekend!


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D





More information about the samba-technical mailing list