[PATCH] ctdb/tests: add missing dependency to libreplace for PTHREAD_MUTEX_ROBUST

Amitay Isaacs amitay at gmail.com
Fri Feb 8 03:28:41 UTC 2019

On Thu, Feb 7, 2019 at 10:16 PM Stefan Metzmacher via samba-technical
<samba-technical at lists.samba.org> wrote:
> Hi Björn,
> > The attached path solves a build issue in the ctdb tests:
> > [2694/3871] Compiling ctdb/tests/src/test_mutex_raw.c
> > ../ctdb/tests/src/test_mutex_raw.c: In function ‘main’:
> > ../ctdb/tests/src/test_mutex_raw.c:332: error: ‘PTHREAD_MUTEX_ROBUST’
> > undeclared (first use in this function)
> >
> > Please review :-)
> I think we want deps='replace pthread'.
> Otherwise it looks good.

NACK.  This test is in ctdb directory just to keep track of it.  It
has nothing to do with samba or ctdb.

It's better to keep this test standalone and not pollute with build
dependencies on samba tree.

Björn, what platform is the build failing on?


More information about the samba-technical mailing list