[PATCH] Fix for XDR Backend of NFS4ACL_XATTR module to get it working with NFS4.0 ACL Spec

[Christoph Kleineweber]

Hi,

Whats the status of this patch? Is there any chance get it merged? Would be
interested in the feature as well.

Kind regards,
Christoph

On Mon, Dec 3, 2018 at 12:23 PM Ralph Böhme via samba-technical <
samba-technical at lists.samba.org> wrote:

> Hi,
>
> On Mon, Dec 03, 2018 at 06:27:42AM +0000, Sandeep Nashikkar wrote:
> >On Fri, Nov 30, 2018 at 18:09 IST Ralph Böhme via samba-technical write
> >> > I tried it with our setup and with following options:
> >> >        nfs4acl_xattr:encoding = nfs
> >> >        nfs4acl_xattr:validate_mode = yes
> >
> >> Why are you enabling this? I thought that doesn't make sense when
> resharing a
> >> NFS4 mount.
> >
> >I was getting Access Denied error on SET ACL, so I thought it is because
> of
> >permission issues. So I enabled this to give 0666 for files and 0777 for
> >folders. Will try without this.
>
> That would be nice. :)
>
> >> >        nfs4acl_xattr:nfs4_id_numeric = yes
> >> >        nfs4acl_xattr:xattr_name = system.nfs4_acl
> >
> >> This is already the default when nfs4acl_xattr:encoding is set to nfs.
> >
> >When nfs4_id_numeric was not set, I was getting BADXDR error from NFS
> server
> >when SET ACL operation does SETXATTR operation.
>
> Yes, sure, I wasn't referring to the nfs4_id_numeric parameter, but
> xattr_name. Of course you have to set nfs4_id_numeric to match your NFS4
> server,
> but the xattr name will be set to "system.nfs4_acl" when
> "nfs4acl_xattr:encoding" is set to "nfs".
>
> >> I guess this should make it into master in time for 4.10.
> >
> >As far as I can read, 4.10 release is March 2019. That will be too late
> for
> >us. Is it possible to backport this patchset to 4.8 or any previous
> versions to
> >get it into one of the available release? That will be really helpful if
> its
> >possible. I am not aware of the criteria which is followed for
> backporting, so
> >please bear with my questions :)
>
> Bugs get backports, new features don't. Which means you have to apply the
> patchset manually on-top of whatever version you ship. The patches should
> apply
> with little fuss on older version.
>
> -slow
>
> --
> Ralph Boehme, Samba Team                https://samba.org/
> Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
> GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46
>
>