Do the tests not like documentation changes or ...
Richard Sharpe
realrichardsharpe at gmail.com
Fri Dec 6 14:31:15 UTC 2019
Hi folks,
I created the following change to the documentation:
--------------------
index 8275d313ed1..948b98936a2 100644
--- a/docs-xml/Samba-Developers-Guide/vfs.xml
+++ b/docs-xml/Samba-Developers-Guide/vfs.xml
@@ -235,14 +235,14 @@ DO NOT ACCESS conn->vfs.ops.* directly !!!
#define SMB_VFS_CLOSE(fsp, fd) \
((fsp)->conn->vfs.ops.close(\
(fsp)->conn->vfs.handles.close, (fsp), (fd)))
-#define SMB_VFS_READ(fsp, fd, data, n) \
+#define SMB_VFS_PREAD(fsp, fd, data, n, off) \
((fsp)->conn->vfs.ops.read(\
(fsp)->conn->vfs.handles.read,\
- (fsp), (fd), (data), (n)))
-#define SMB_VFS_WRITE(fsp, fd, data, n) \
+ (fsp), (fd), (data), (n), (off)))
+#define SMB_VFS_PWRITE(fsp, fd, data, n, off) \
((fsp)->conn->vfs.ops.write(\
(fsp)->conn->vfs.handles.write,\
- (fsp), (fd), (data), (n)))
+ (fsp), (fd), (data), (n), (off)))
#define SMB_VFS_LSEEK(fsp, fd, offset, whence) \
((fsp)->conn->vfs.ops.lseek(\
(fsp)->conn->vfs.handles.lseek,\
------------------
I did a build locally to ensure every thing looked OK.
I then created a PR (merge request) on GitLab, and it failed.
(https://gitlab.com/samba-team/samba/merge_requests/975)
Did I do something wrong?
Is there something else I should have done?
--
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)(传说杜康是酒的发明者)
More information about the samba-technical
mailing list