Do the tests not like documentation changes or ...

Richard Sharpe realrichardsharpe at
Fri Dec 6 14:31:15 UTC 2019

Hi folks,

I created the following change to the documentation:

index 8275d313ed1..948b98936a2 100644
--- a/docs-xml/Samba-Developers-Guide/vfs.xml
+++ b/docs-xml/Samba-Developers-Guide/vfs.xml
@@ -235,14 +235,14 @@ DO NOT ACCESS conn->vfs.ops.* directly !!!
 #define SMB_VFS_CLOSE(fsp, fd) \
        (fsp)->conn->vfs.handles.close, (fsp), (fd)))
-#define SMB_VFS_READ(fsp, fd, data, n) \
+#define SMB_VFS_PREAD(fsp, fd, data, n, off) \
-        (fsp), (fd), (data), (n)))
-#define SMB_VFS_WRITE(fsp, fd, data, n) \
+        (fsp), (fd), (data), (n), (off)))
+#define SMB_VFS_PWRITE(fsp, fd, data, n, off) \
-        (fsp), (fd), (data), (n)))
+        (fsp), (fd), (data), (n), (off)))
 #define SMB_VFS_LSEEK(fsp, fd, offset, whence) \

I did a build locally to ensure every thing looked OK.

I then created a PR (merge request) on GitLab, and it failed.

Did I do something wrong?

Is there something else I should have done?

Richard Sharpe

More information about the samba-technical mailing list