[PATCH] ctdb-daemon: Make STOP_NODE control wait until complete (bug 14087)

Martin Schwenke martin at meltin.net
Mon Aug 19 04:34:31 UTC 2019

On Sat, 17 Aug 2019 10:24:47 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:

> STOP_NODE is supported by a periodic check in the recovery daemon's
> main_loop(), which notices the flag change, and schedules a recovery
> and freezes databases.  If STOP_NODE returns immediately then the
> associated recovery can complete and the node can be continued before
> databases are actually frozen.  This means that the databases on the
> stopped node will node never be marked invalid and the recovery
> following CONTINUE_NODE can resurrect deleted records.
> CONTINUE_NODE must wait for an in-progress STOP_NODE to complete
> before commencing.
> Multiple STOP_NODE controls are also serialised.  This isn't strictly
> necessary but will stop more deeply nested event loops.
> Went through this pipelines with a slightly different commit message:
>   https://gitlab.com/samba-team/devel/samba/pipelines/76501176
> Now running in this one:
>   https://gitlab.com/samba-team/devel/samba/pipelines/76849217
> Please review and maybe push...

Now with patch!  :-)

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-daemon-Make-STOP_NODE-control-wait-until-comple.patch
Type: text/x-patch
Size: 2108 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190819/d400b3e7/0001-ctdb-daemon-Make-STOP_NODE-control-wait-until-comple.bin>

More information about the samba-technical mailing list