[PATCH] CTDB TCP transport connectivity fixes (bug 14084)

[Martin Schwenke]

On Wed, 14 Aug 2019 14:22:27 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Wed, Aug 14, 2019 at 1:54 PM Martin Schwenke via samba-technical
> <samba-technical at lists.samba.org> wrote:
> >
> > Fix for:
> >
> >   https://bugzilla.samba.org/show_bug.cgi?id=14084
> >
> > The solution is to only mark nodes as connected when both incoming and
> > outgoing connections are up.
> >
> > Included in this pipeline:
> >
> >   https://gitlab.com/samba-team/devel/samba/pipelines/76265339
> >
> > Please review and maybe push...  
> 
> In the last patch, there is no need to add "node" element to "tnode".
> "tnode" already includes "ctdb" for upcalls.

It is needed to be able to easily pass the node as the argument to the
upcall.

However, you're right that:

  tnode->node->ctdb->upcalls->node_dead(tnode->node);

could just be:

  tnode->ctdb->upcalls->node_dead(tnode->node);

Do you want to tweak it or should I?

peace & happiness,
martin