[PATCH] Revert "wafsamba: Enable warnings for missing field initializer"

[Andrew Bartlett]

On Mon, 2019-04-29 at 16:21 -0700, Christof Schmitt wrote:
> On Tue, Apr 30, 2019 at 10:58:06AM +1200, Andrew Bartlett wrote:
> > On Mon, 2019-04-29 at 15:32 -0700, Christof Schmitt via samba-technical 
> > wrote:
> > > On Mon, Apr 29, 2019 at 01:08:09PM -0700, Christof Schmitt via samba-technical wrote:
> > > > On Mon, Apr 29, 2019 at 09:51:53PM +0200, Ralph Böhme wrote:
> > > > > Hey Christof
> > > > > 
> > > > > > Am 29.04.2019 um 21:36 schrieb Christof Schmitt <cs at samba.org>:
> > > > > > 
> > > > > > Revert the patch adding the warnings since that causes problems when
> > > > > > compiling master on RHEL7. Many C99 initializers of nested structs
> > > > > > are flagged as problematic, so it seems easier to remove the
> > > > > > additional compiler checks.
> > > > > 
> > > > > sorry, didn't thought about older compilers...
> > > > > 
> > > > > Can we have a compiler check that ensures {0} works included with
> > > > > nested structs and then only enable the -Wmissing-field-initializers
> > > > > if it does?
> > > > 
> > > > That should be doable. Let met try adding the check.
> > > 
> > > See attached patch. That works for me on RHEL7 (skipping the compiler
> > > option) and Fedora 29 (using the compiler option).
> > 
> > Could you make this a merge request please, so we can see it working on
> > all the platforms tested there?
> 
> Yes. CI is running now at
> https://gitlab.com/samba-team/devel/samba/pipelines/59040252

Thanks, then you just need to make it a merge request please.  That way
we can see the patch and pipeline together, and it is in the todo list
of merge requests here:
https://gitlab.com/samba-team/samba/merge_requests

Instructions are at: 
https://wiki.samba.org/index.php/Samba_CI_on_gitlab#Creating_a_merge_request

> > Also, could you please look into adding CentOS 7 as a supported
> > platform via our bootstrap system so we don't regress here in the
> > future?  There is partial support already, but it wasn't finished
> > (mostly to avoid chasing two rabbits at once). 
> 
> That is a new area to me. I see that CentOS is listed under
> bootstrap/generated-dists/centos7/. Would the only missing piece be the
> centos7 entries in .gitlab-ci.yml, or am i missing something? I can give
> that a try tomorrow.

The main task is to make the build pass, but that is what you are
wanting anyway.  

See https://gitlab.com/samba-team/samba/blob/master/bootstrap/READMD.md

The idea is to make the image work by setting
SAMBA_CI_REBUILD_BROKEN_IMAGES="yes" in 
https://gitlab.com/samba-team/devel/samba/pipelines/new and once that
works, modify this:

https://gitlab.com/samba-team/samba/blob/master/bootstrap/.gitlab-ci.yml

To remove the _force_broken.

You might need to fix Samba code, make configure less strict when
running the -o3 build, or add packages.

The others CC'ed here should be able to help also.

All the best!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba