[PATCH] Revert "wafsamba: Enable warnings for missing field initializer"

[Andrew Bartlett]

On Mon, 2019-04-29 at 15:32 -0700, Christof Schmitt via samba-technical 
wrote:
> On Mon, Apr 29, 2019 at 01:08:09PM -0700, Christof Schmitt via samba-technical wrote:
> > On Mon, Apr 29, 2019 at 09:51:53PM +0200, Ralph Böhme wrote:
> > > Hey Christof
> > > 
> > > > Am 29.04.2019 um 21:36 schrieb Christof Schmitt <cs at samba.org>:
> > > > 
> > > > Revert the patch adding the warnings since that causes problems when
> > > > compiling master on RHEL7. Many C99 initializers of nested structs
> > > > are flagged as problematic, so it seems easier to remove the
> > > > additional compiler checks.
> > > 
> > > sorry, didn't thought about older compilers...
> > > 
> > > Can we have a compiler check that ensures {0} works included with
> > > nested structs and then only enable the -Wmissing-field-initializers
> > > if it does?
> > 
> > That should be doable. Let met try adding the check.
> 
> See attached patch. That works for me on RHEL7 (skipping the compiler
> option) and Fedora 29 (using the compiler option).

Could you make this a merge request please, so we can see it working on
all the platforms tested there?

Also, could you please look into adding CentOS 7 as a supported
platform via our bootstrap system so we don't regress here in the
future?  There is partial support already, but it wasn't finished
(mostly to avoid chasing two rabbits at once). 

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba