[PATCH] Revert "wafsamba: Enable warnings for missing field initializer"

Christof Schmitt cs at samba.org
Mon Apr 29 22:27:21 UTC 2019

On Tue, Apr 30, 2019 at 10:08:22AM +1200, Andrew Bartlett via samba-technical wrote:
> On Mon, 2019-04-29 at 12:36 -0700, Christof Schmitt via samba-technical 
> wrote:
> > Revert the patch adding the warnings since that causes problems when
> > compiling master on RHEL7. Many C99 initializers of nested structs are
> > flagged as problematic, so it seems easier to remove the additional
> > compiler checks.
> Shouldn't older OS versions just not be compiled with --picky-
> developer?
> I don't mind if a test is added to wscript to detect and fail --picky-
> developer on such hosts, but RHEL7 is actually just as old as Ubuntu
> 14.04 which we just retired. 

The main difference between Ubuntu 14.04 and RHEL7 seems to be the
support cycle. I still see RHEL7 in commonly used.  I was wrong about
"picky developer", the option is currently added for all developer

For the time being, I would like to keep the ability to build and test
master on RHEL7. If others object, this is ok with me.

> Hopefully RHEL8 is just around the corner.

Maybe, but due to the long support cycle, RHEL7 will likely still be
in common use for the next year or two.


More information about the samba-technical mailing list