[PATCH] Revert "wafsamba: Enable warnings for missing field initializer"

Andrew Bartlett abartlet at samba.org
Mon Apr 29 22:08:22 UTC 2019


On Mon, 2019-04-29 at 12:36 -0700, Christof Schmitt via samba-technical 
wrote:
> Revert the patch adding the warnings since that causes problems when
> compiling master on RHEL7. Many C99 initializers of nested structs are
> flagged as problematic, so it seems easier to remove the additional
> compiler checks.

Shouldn't older OS versions just not be compiled with --picky-
developer?

I don't mind if a test is added to wscript to detect and fail --picky-
developer on such hosts, but RHEL7 is actually just as old as Ubuntu
14.04 which we just retired. 

Hopefully RHEL8 is just around the corner.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list