[PATCH] Revert "wafsamba: Enable warnings for missing field initializer"

Christof Schmitt cs at samba.org
Mon Apr 29 20:08:09 UTC 2019


On Mon, Apr 29, 2019 at 09:51:53PM +0200, Ralph Böhme wrote:
> Hey Christof
> 
> > Am 29.04.2019 um 21:36 schrieb Christof Schmitt <cs at samba.org>:
> > 
> > Revert the patch adding the warnings since that causes problems when
> > compiling master on RHEL7. Many C99 initializers of nested structs
> > are flagged as problematic, so it seems easier to remove the
> > additional compiler checks.
> 
> sorry, didn't thought about older compilers...
> 
> Can we have a compiler check that ensures {0} works included with
> nested structs and then only enable the -Wmissing-field-initializers
> if it does?

That should be doable. Let met try adding the check.

Christof



More information about the samba-technical mailing list