[PATCH] #ifdef code cleanup

Andrew Bartlett abartlet at samba.org
Sat Apr 27 01:29:20 UTC 2019


On Sat, 2018-11-24 at 10:58 +0100, Ralph Böhme via samba-technical
wrote:
> On Sat, Nov 24, 2018 at 10:42:05AM +1300, Andrew Bartlett via samba-
> technical wrote:
> > 
>> > I did a test on my host with the script I suggested last night,
> > fixed
> > up to finally work.
> > 
> > I had to revert:
> > 
> > s3: Remove unsused MMAP_BLACKLIST ifdef checks
> > lib:replace: Check if HAVE_DECL_ENVIRON is defined first
> > 
> > (these can be reasoned about independently).
> > 
> > To make it give the (almost) identical results you see below.
> the gcc -E trick is really nice. Can we put that somewhere in the
> wiki? If you 
> have a suggestion where to put it, I'll happily volunteer to make the
> change. :)

I added it here:

https://wiki.samba.org/index.php/Testing_removal_of_ifdef_or_configure_checks

Also, I think Douglas has the knack for doing this with the ASM output
as well, which is less sensitive to line numbers.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list