[PATCH] DON'T PANIC!
Ralph Böhme
slow at samba.org
Tue Apr 23 11:41:51 UTC 2019
Hi David,
> Am 16.04.2019 um 14:33 schrieb David Disseldorp <ddiss at samba.org>:
>
> Hi Ralph,
>
> On Tue, 16 Apr 2019 14:02:47 +0200, Ralph Böhme wrote:
>
>> On Mon, Apr 01, 2019 at 11:37:36AM +0200, Ralph Böhme via samba-technical wrote:
>>> ping. :)
>>
>> 100% packet loss
>>
>> ping
>
> Sorry about the packet loss, but my opinion hasn't changed here - I
> still think panicking when the underlying filesystem has failed is
> more desirable than exiting with 0.
well, we log the underlying error so the logs contain all that's needed to analyse the problem. A SBT doesn't add anything helpful in this case.
I guess we should generally only panick when facing an unrecoverable error in a Samba subsystem. In that case a SBT really helps, for every other case you just create work for the support team.
Thoughts?
-slow
--
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG-Fingerprint FAE2C6088A24252051C559E4AA1E9B7126399E46
More information about the samba-technical
mailing list