Add multichannel tests to smbtorture

[Sachin Prabhu]

On Wed, Apr 17, 2019 at 7:25 PM Jeremy Allison via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> On Wed, Apr 17, 2019 at 10:33:10AM -0700, Jeremy Allison via samba-technical wrote:
> > On Tue, Apr 16, 2019 at 04:54:50PM +0200, Günther Deschner wrote:
> > > On 27/03/2019 19:31, Jeremy Allison via samba-technical wrote:
> > > > Guenther, are you able to be second Team reviewer here ?
> > >
> > > Yes, of course :) Sorry, forgot to mention that all of these patches
> > > were reviewed by me earlier, so Sachin, please upload the same series
> > > with my RB+ added :)
> >
> > Only two comments:
> >
> > [PATCH 03/19] s4-torture: move oplock break handler out of the replay testsuite.
> >
> > Add include guards around new source4/torture/smb2/oplock_break_handler.h file.
> >
> > PATCH 09/19] s4-torture: add torture_block/torture_unblock smb2 transport functions
> >
> > Change: samba_chain_name(..., bool) -> samba_chain_name(..., const char *prefix)
> >
> > where prefix is passed as "SAMBA_INPUT" or "SAMBA_OUTPUT" instead
> > of 'true'/'false'. bool args make it impossible to see what this
> > is doing without looking inside the function, using the strings
> > directly make it obvious.
> >
> > Unfortunately when I compile to test I'm getting errors using:
> >
> > --enable-developer --picky-developer
> >
> > Errors are below. Can you fix these up and resubmit please ?
> >
> > Most of them are just things like adding "const" to the last
> > argument of _test_block_channel() etc. and removing unused
> > variables.
>
> Just to prove I can be helpful :-), here is a fixed up
> patchset that removes all errors I found (and includes
> the changes I requested). Still fails with:
>
> [3208/4213] Compiling source4/torture/smb2/multichannel.c
> ../../source4/torture/smb2/multichannel.c: In function ‘test_ioctl_network_interface_info’:
> ../../source4/torture/smb2/multichannel.c:135:15: error: ‘struct <anonymous>’ has no member named ‘max_response_size’
>   ioctl.smb2.in.max_response_size = 0x10000;
>                ^
> ../../source4/torture/smb2/multichannel.c: In function ‘test_multichannel_create_channel’:
> ../../source4/torture/smb2/multichannel.c:178:7: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
>   bool ret = true;
>        ^~~
> cc1: all warnings being treated as errors
>
> Waf: Leaving directory `/space/jra/src/samba/git/reviews/bin/default'
> Build failed
>
> but should be a much cleaner base to work with to
> fix up these last fiddly errors.

Hello Jeremy,

Thanks for pointing out the errors. I had removed the
--picky-developer option from my workflow because of some problems I
was facing with the rawhide development environment.

Unfortunately I saw this email after I made the necessary changes but
thanks again for posting the patches.

I believe that the error
> ../../source4/torture/smb2/multichannel.c:135:15: error: ‘struct <anonymous>’ has no member named ‘max_response_size’
>   ioctl.smb2.in.max_response_size = 0x10000;

was because of changes introduced by the patch
97b4e6e220d s4:libcli/smb2: align struct smb_ioctl.smb2 to [MS-SMB2] names
I was using an older base and didn't have these new changes.

I am testing the patches at this moment and will post as soon as I
have completed testing them.

Sachin Prabhu

>
> Cheersm
>
>         Jeremy.