avahi not registering services with port number "0". added patch.

[Günther Deschner]

Hi Rouven,

hm, the attached patch had 0 bytes. Can you re-send the patch ?

Thanks,
Guenther

On 02/04/2019 13:54, Rouven WEILER via samba-technical wrote:
> 
> In avahi.c there are two mdns services registered under port number "0" for propagation. The two services for the fuit:model named "_device-info" and "_adisk" are not propagated properly under.
> 
> Digging on MacOS shows that "_adisk" uses e.g. port number 9 in the TimeCapsule. "_device-info" is not a service at all due to IANA. It is just a TXT entry. The mDNSResponder in MacOS does propagate that at startup. This function is not ported to other implementation. Setting "_device-info" being propagated on port 9 does then work well.
> 
> Summed up: Setting both port number to 9 make everything work well. Since "9" is the "discard" port (to my knowledge something like a network "/dev/null") and since there is no real service behind "_device-info" and "_adisk" setting the ports seem reasonable to me.
> 
> Additional info: https://www.illumos.org/issues/10577
> 


-- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190416/e3081438/signature.sig>