[PATCH] s4:heimdal_build: fix --nonshared-binary=smbpasswd failure by rep_closefrom

Andrew Bartlett abartlet at samba.org
Fri Apr 12 08:20:19 UTC 2019

On Fri, 2019-04-12 at 14:09 +0800, Jones Syue via samba-technical
> Hello Metze,
> v2.patch could address both
> 1. --nonshared-binary=smbpasswd failure
> 2. a lot of "... has been redefined" compiler warnings
> please help review and push (or should i file a bug first), thank
> you.

Thanks so much for having a go with patching this, we really appriciate

Regarding this specific patch, we need to do a couple of things
differently, and add a test to prevent a regression when we next update

Specifically we need to avoid changing roken.h.in as that is an
upstream Heimdal file, we need to get this working with changes just
under heimdal_build if at all possible.

We also need to keep this tested by extending the samba-static rule in

If you are on gitlab.com we can also give you access to the CI repo for
testing if you let us know your username.  

Full instructions and how to request access is at:

Finally yes, a bug is always a good thing to file, the add the BUG: tag
to the commit.

Thanks for your patience and perseverance with this!

Andrew Bartlett

> --
> Regards,
> Jones Syue | 薛懷宗
> QNAP Systems, Inc.
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list