[PATCH] ctdb-daemon: Revert "We can not assume that just because we could complete a TCP handshake" (bug 13888)

Amitay Isaacs amitay at gmail.com
Fri Apr 12 07:03:00 UTC 2019


On Fri, Apr 12, 2019 at 4:31 PM Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> We also can not assume that nodes can be marked as connected via only
> the keepalive mechanism.  Keepalives are not sent to disconnected
> nodes so, in the absence of other packets (e.g. broadcasts), 2 nodes
> may never become marked as connected to each other.
>
> Revert to marking nodes as connected in the TCP transport code.  If a
> connection is to a non(-operational) ctdbd then it will revert to
> disconnected after a short while and may actually flap.  This should
> be rare.
>
> This reverts commit 66919db3d7ab1e091223faf515b183af8bfddc83.
>
> peace & happiness,
> martin

Pushed to autobuild.

Amitay.



More information about the samba-technical mailing list