[PATCH] enable logging for early startup failures

Ralph Wuerthner ralphw at de.ibm.com
Thu Apr 11 11:27:29 UTC 2019


On 11.04.19 01:30, Christof Schmitt wrote:
> On Wed, Apr 10, 2019 at 10:30:40AM +0200, Ralph Böhme via samba-technical wrote:
>>
>>
>>> Am 10.04.2019 um 10:10 schrieb Ralph Wuerthner via samba-technical <samba-technical at lists.samba.org>:
>>>
>>> Anybody?
>>
>> me! :)
>>
>> Lgtm. Second team reviewer please.
> 
> Looks good to me. I don't see a much better way to initialize logging.
> There is the special case of not having WITH_SYSLOG, but that is handled
> in debug.c
> 
> RB+
> 
> The only other thought is that the newer struct initializers could be
> used, but that is just a minor comment.:
> 
> 		struct debug_settings settings = {
> 			.max_log_size = 5000,
> 			.timestamp_logs = true,
> 			.debug_prefix_timestamp = false,
> 			.debug_hires_timestamp = true,
> 			.debug_pid = false,
> 			.debug_uid = false,
> 			.debug_class = false,
> 		};
> 		debug_set_settings(&settings,
> 				   "syslog at 0",
> 				   1,
> 				   false);
> 
> 
> Christof

Yes, you're right, this would be better. Please see the new version of 
the patch set which is using a struct initializer.

-- 
Regards

Ralph Wuerthner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-debug-enable-logging-for-early-startup-failures-v2.patch
Type: text/x-patch
Size: 3890 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190411/d98c3117/0001-s3-debug-enable-logging-for-early-startup-failures-v2.bin>


More information about the samba-technical mailing list