[PATCH] enable logging for early startup failures

Christof Schmitt cs at samba.org
Wed Apr 10 23:30:16 UTC 2019


On Wed, Apr 10, 2019 at 10:30:40AM +0200, Ralph Böhme via samba-technical wrote:
> 
> 
> > Am 10.04.2019 um 10:10 schrieb Ralph Wuerthner via samba-technical <samba-technical at lists.samba.org>:
> > 
> > Anybody?
> 
> me! :)
> 
> Lgtm. Second team reviewer please.

Looks good to me. I don't see a much better way to initialize logging.
There is the special case of not having WITH_SYSLOG, but that is handled
in debug.c

RB+

The only other thought is that the newer struct initializers could be
used, but that is just a minor comment.:

		struct debug_settings settings = {
			.max_log_size = 5000,
			.timestamp_logs = true,
			.debug_prefix_timestamp = false,
			.debug_hires_timestamp = true,
			.debug_pid = false,
			.debug_uid = false,
			.debug_class = false,
		};
		debug_set_settings(&settings,
				   "syslog at 0",
				   1,
				   false);


Christof



More information about the samba-technical mailing list