[PATCH] vfs_full_audit: Fix logging of get_real_filename output

Jeremy Allison jra at samba.org
Wed Apr 10 00:05:18 UTC 2019


LGTM. RB+ and pushed !

On Tue, Apr 09, 2019 at 02:40:04PM -0700, Christof Schmitt via samba-technical wrote:
> From 8a927516f003535dd0672bff7d97e7a3698858e1 Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Tue, 9 Apr 2019 13:57:36 -0700
> Subject: [PATCH] vfs_full_audit: Fix logging of get_real_filename output
> 
> result == 0 indicated success. In that case log the available
> found_name.
> 
> Signed-off-by: Christof Schmitt <cs at samba.org>
> ---
>  source3/modules/vfs_full_audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/modules/vfs_full_audit.c b/source3/modules/vfs_full_audit.c
> index fcfb024d493..a4e2afa0dbb 100644
> --- a/source3/modules/vfs_full_audit.c
> +++ b/source3/modules/vfs_full_audit.c
> @@ -1852,7 +1852,7 @@ static int smb_full_audit_get_real_filename(struct vfs_handle_struct *handle,
>  						found_name);
>  
>  	do_log(SMB_VFS_OP_GET_REAL_FILENAME, (result == 0), handle,
> -	       "%s/%s->%s", path, name, (result == 0) ? "" : *found_name);
> +	       "%s/%s->%s", path, name, (result == 0) ? *found_name : "");
>  
>  	return result;
>  }
> -- 
> 2.17.0
> 



More information about the samba-technical mailing list