[PATCHES v2 BUG 13865] Properly track the size of talloc objects
jra at samba.org
Sat Apr 6 05:10:58 UTC 2019
On Fri, Apr 05, 2019 at 03:52:30PM -0700, Christof Schmitt via samba-technical wrote:
> > Yeah, thinking about this some more I'm OK with 512k or 1Mb.
> > I'll let you chose and send the patch :-).
> Let's go with 512kB then.
> Ok. I attached all patches, including the one for the size change.
> From 61f6898ec295cec9c71a151d8c6e028b19b28289 Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Fri, 5 Apr 2019 15:43:21 -0700
> Subject: [PATCH 3/4] memcache: Increase size of default memcache to 512k
> With the fixed accounting of talloc objects, the default cache size
> needs to increase. The exact increase required depends on the workloads,
> going form 256k to 512k seems like a reasonable guess.
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13865
> Signed-off-by: Christof Schmitt <cs at samba.org>
The above patch also need the size changed in:
diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index 7ef2cc7d3f6..ebbccc22b71 100644
@@ -2945,7 +2945,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
lpcfg_do_global_parameter(lp_ctx, "durable handles", "yes");
- lpcfg_do_global_parameter(lp_ctx, "max stat cache size", "256");
+ lpcfg_do_global_parameter(lp_ctx, "max stat cache size", "512");
lpcfg_do_global_parameter(lp_ctx, "ldap passwd sync", "no");
Re-pushed with this change.
More information about the samba-technical