[PATCHES v2 BUG 13865] Properly track the size of talloc objects
Jeremy Allison
jra at samba.org
Fri Apr 5 22:10:11 UTC 2019
On Fri, Apr 05, 2019 at 03:09:09PM -0700, Jeremy Allison wrote:
> On Fri, Apr 05, 2019 at 02:21:55PM -0700, Christof Schmitt via samba-technical wrote:
> > Ping. Does anybody want to review? The pipeline now passes.
>
> OK, LGTM and RB+. Feel free to push to master.
> Thanks for helping me track down the issues
> with it originally.
>
> But we also must think about the effect this
> will have on the size settings for the global
> cache.
>
> Right now we do:
>
> smbd_memcache_ctx = memcache_init(NULL, lp_max_stat_cache_size()*1024);
> memcache_set_global(smbd_memcache());
>
> where max stat cache size = 256.
>
> This means we have a 256k total size global memcache.
>
> Previously we're only storing an 8 byte
> pointer (on a 64-bit platform) per talloc
> object going into the global cache.
The above means for all practical purposes
we never evict from the cache I meant to
add.
More information about the samba-technical
mailing list