building samba 4.9.x with python > 2.6

[Rowland Penny]

On Fri, 5 Apr 2019 06:37:52 +1100
Alex Braunegg via samba-technical <samba-technical at lists.samba.org>
wrote:

> The proposed patch still generates an error as compiled with 4.9.5:
> 
> ERROR(<type 'exceptions.IndexError'>): uncaught exception - tuple
> index out of range File
> "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", line
> 177, in _run return self.run(*args, **kwargs) File
> "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line
> 538, in run backend_store=backend_store) File
> "/usr/lib64/python2.6/site-packages/samba/provision/__init__.py",
> line 2316, in provision backend_store=backend_store) File
> "/usr/lib64/python2.6/site-packages/samba/provision/__init__.py",
> line 1921, in provision_fill names.domaindn, lp, use_ntvfs) File
> "/usr/lib64/python2.6/site-packages/samba/provision/__init__.py",
> line 1693, in setsysvolacl userdn = '<SID={1}-{2}>'.format(domainsid,
> security.DOMAIN_RID_ADMINISTRATOR)

I am not a python expert (far from it), but doesn't python start
counting from '0' ?
If so, shouldn't `userdn = '<SID={1}-{2}>'.format(domainsid,
security.DOMAIN_RID_ADMINISTRATOR)` be `userdn =
'<SID={0}-{1}>'.format(domainsid, security.DOMAIN_RID_ADMINISTRATOR)`

Rowland