[PATCH] Fixes for bug 13873 (Py 3 bug on 4.10)

David Mulder dmulder at suse.com
Wed Apr 3 19:41:36 UTC 2019


On 4/2/19 9:05 PM, Tim Beale via samba-technical wrote:
> Someone on the samba mailing-list found an interesting problem with
> Python3 on 4.10 this week.
> https://bugzilla.samba.org/show_bug.cgi?id=13873
> We were taking a parameter that defaulted to None and comparing it to an
> integer value. On Python 3 this now throws an exception. The code is
> still incorrect, even with Python 2 (None is always less than any
> integer, so the comparison would never do anything sensible). The
> difference is we now get an exception, rather than silently skipping
> that particular block of code.
> Attached is a fix for the problem, along with a test to highlight the
> buggy 'samba-tool domain passwordsettings set' command.
> CI pass*: https://gitlab.com/catalyst-samba/samba/pipelines/54912258
> *Note I had to apply a separate patch (also attached) to get around the
> flappy samba3.smb2.notify.valid-req test. I think Gary is just going to
> mark the test as flapping, which is probably a better option.

*David Mulder*
Labs Software Engineer, Samba
1800 Novell Place Provo, UT 84606
(P)+1 801.861.6571
dmulder at suse.com

More information about the samba-technical mailing list