Samba and prefork test with MIT Kerberos

[Gary Lockyer]

Andreas
       The attached patch set should disable the pre-fork restart tests
for MIT Kerberos builds.

Merge request: https://gitlab.com/samba-team/samba/merge_requests/355
CI: https://gitlab.com/samba-team/devel/samba/pipelines/54907464

Ngā mihi
Gary

On 26/03/19 03:57, Andreas Schneider via samba-technical wrote:
> Hi Gary,
> 
> the test samba.tests.prefork_restart(preforkrestartdc:local) fails if built 
> with MIT Kerberos.
> 
> UNEXPECTED(failure): 
> samba.tests.prefork_restart.samba.tests.prefork_restart.PreforkProcessRestartTests.test_master_restart_backoff(preforkrestartdc:local)
> REASON: Exception: Exception: Traceback (most recent call last):
>   File "bin/python/samba/tests/prefork_restart.py", line 408, in 
> test_master_restart_backoff                                                                                                     
> self.assertIsNotNone(pid)                                                                                                                                                                
> AssertionError: unexpectedly None
> 
> If you build with MIT Kerberos, there is no such process. But there is a 
> krb5kdc process running.
> 
> The same happens in line 453.
> 
> Could you please adopt the test that it works with MIT Kerberos?
> 
> 
> Thanks,
> 
> 
> 	Andreas
> 
-------------- next part --------------
From 4c7a0ff1253077825688136e429e3d8e71d8bfb9 Mon Sep 17 00:00:00 2001
From: Gary Lockyer <gary at catalyst.net.nz>
Date: Wed, 27 Mar 2019 13:52:37 +1300
Subject: [PATCH] prefork tests: disable restart tests MIT

The prefork restart tests use the kdc to test restart back off.  These
tests need to use a process that has not been restarted to ensure that
the process restart counters are sitting at 0 when the tests start.

As MIT kerberos is experimental the heimdal builds will still ensure
that this functionality is tested.

At some stage the echo server should be converted to run in pre-fork and
this process can then be used to test the restart backoff.

Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
---
 selftest/skip_mit_kdc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/selftest/skip_mit_kdc b/selftest/skip_mit_kdc
index 4a51c98ea0b..bef52f50f86 100644
--- a/selftest/skip_mit_kdc
+++ b/selftest/skip_mit_kdc
@@ -3,3 +3,7 @@
 .*RODC
 ^samba4.ntvfs.cifs.ntlm.base.unlink
 ^samba4.ntvfs.cifs.krb5.base.unlink
+#
+# We skip the pre-fork restart tests as they use the kdc process to test
+# restart back off
+^samba.tests.prefork_restart
-- 
2.18.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190403/02362fcc/signature.sig>