[PATCH] fix for valgrind errors in master - smbtorture3 POSIX test.

Ralph Böhme slow at samba.org
Thu Sep 27 21:25:29 UTC 2018


On Thu, Sep 27, 2018 at 02:16:47PM -0700, Jeremy Allison wrote:
>On Thu, Sep 27, 2018 at 02:06:32PM -0700, Jeremy Allison via samba-technical wrote:
>> > ah, but fsp_free() is not called in the close_cnum() case. Heavens!
>>
>> Found it - missing:
>>
>> file_free(req, fsp);
>>
>> calls in close_directory() error paths...
>
>Here is the fix. The POSIX test is now valgrind
>clean.

ah, that makes sense.

Pushed. Thanks!
-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46



More information about the samba-technical mailing list