valgrind errors in smbd/master

[Ralph Böhme]

On Thu, Sep 27, 2018 at 02:00:31PM -0700, Ralph Böhme wrote:
>On Thu, Sep 27, 2018 at 01:31:22PM -0700, Jeremy Allison wrote:
>>On Thu, Sep 27, 2018 at 01:13:29PM -0700, Ralph Böhme via samba-technical wrote:
>>>On Thu, Sep 27, 2018 at 12:21:41PM -0700, Jeremy Allison wrote:
>>>> Hi all,
>>>>
>>>> Can you take a look at:
>>>>
>>>> https://bugzilla.samba.org/show_bug.cgi?id=13633
>>>>
>>>> I was trying to track down some valgrind errors in
>>>> my SMB2 POSIX extensions branch, and discovered I
>>>> get the same errors in pristine master (no SMB2
>>>> POSIX changes).
>>>>
>>>> I'll also take a look, but the problems on session
>>>> shutdown / server termination have been a perennial
>>>> pain here :-(.
>>>
>>>looking...
>>
>>Yeah I'm making some progress here.
>>
>>Calling close_cnum() is leaving a fsp entry
>>on the conn->sconn->files linked list whose
>>parent is the 'conn' being deleted.
>>
>>close_cnum() should have removed it.
>
>strange. fsp_free() does call DLIST_REMOVE(sconn->files, fsp) so it 
>should be removed from the list.

ah, but fsp_free() is not called in the close_cnum() case. Heavens!

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46