[PATCH] Some minor SMB fixes

Ralph Böhme slow at samba.org
Thu Sep 27 05:14:41 UTC 2018

On Thu, Sep 27, 2018 at 02:48:44PM +1200, Tim Beale via samba-technical wrote:
>The main change (patch #2) is that in Samba v4.9 the smbd server has
>started responding incorrectly if it can't negotiate an SMB protocol. In
>the SMBnegprot response message, instead of responding with
>DialectIndex=0xffff, it now responds with DialectIndex=0 (i.e. a valid
>protocol choice). This misleads the client into continuing
>(unsuccessfully) to establish the SMB connection. This was introduced by
>a compiler warning fix (commit 06940155f31).
>The other patches are minor changes to make sure the backup tool always
>negotiates a signed SMB connection, and to add a better debug/error
>message if an SMB protocol can't be negotiated.
>CI link: https://gitlab.com/catalyst-samba/samba/pipelines/31315445
>Review appreciated.

oh, good catch, thanks! I'll try to look at it tomorrow.

This is the second (major) regression that I become aware of introduced by 
fixing compiler warning ons (iirc) newly introduced warning levels. Guess we have 
to be a little bit more careful here. :)


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list