[PATCH] s3: Fix the build when compiling without JSON support

Andrew Bartlett abartlet at samba.org
Mon Sep 24 17:35:47 UTC 2018


On Mon, 2018-09-24 at 09:29 +0200, Philipp Gesang via samba-technical
wrote:
> -<| Quoting Andrew Bartlett <abartlet at samba.org>, on Monday, 2018-09-
> 24 04:02:33 PM |>-
> > 
> > On Sun, 2018-09-23 at 14:45 -0700, Ralph Böhme wrote:
> > > 
> > > On Sun, Sep 23, 2018 at 11:23:39AM -0700, Andrew Bartlett wrote:
> > > > 
> > > > 
> > > > Sure the build needs to be fixed, but it still needs to be
> > > > controlled
> > > > by a --without-json, otherwise this remains untested and we get
> > > > back to
> > > > the unsatisfactory 'build contents depends on what is on the
> > > > build
> > > > host' situation.
> > > yep. :)
> > > 
> > > -slow
> > Philipp,
> > 
> > Can you have a go at addressing this by making all of our JSON
> > functionality controlled by a --without-json similar to the
> > current 
> > --without-json-audit?
> Is --without-json to supersede --without-json-audit or should
> the latter continue to exist so JSON can be disabled locally for
> the audit component?

It should supersede --without-json-audit.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list