[PATCH] s3: Fix the build when compiling without JSON support

[Andrew Bartlett]

On Sun, 2018-09-23 at 18:48 +1000, Martin Schwenke wrote:
> Hi Andrew,
> 
> On Sat, 22 Sep 2018 16:26:09 -0700, Andrew Bartlett
> <abartlet at samba.org> wrote:
> 
> > 
> > On Sun, 2018-09-23 at 09:01 +1000, Martin Schwenke via samba-
> > technical
> > wrote:
> > > 
> > > Commit 5534b9248fa375799ad4bc6f45a69dcf14e6419e broke the build
> > > when
> > > JSON support is not configured.
> > > 
> > > Please review and maybe push...
> > 
> > Drat.  Given we are now finding more good uses for this encoding,
> > we
> > should rename the --without-json-audit parameter to --without-json, 
> > fix
> > that to control all JSON and adjust the samba-fileserver autobuild
> > target to match.  That way we will again have a test for this mode.
> >  (I
> > missed that it wasn't controlled properly when I did the review). 
> > 
> > The alternative would be to require it for any build except --
> > without-
> > ads, as we already do for the AD DC.  Certainly we do need a truly
> > minimal build, but it is proving a very useful encoding and we
> > might
> > want to just bite the bullet. 
> > 
> > (CC'ing Ralph because we had a great chat this week about the
> > implications of the dependency here on packagers). 
> That all sounds fab... but in the short term can we please fix the
> build?  :-)

Sure the build needs to be fixed, but it still needs to be controlled
by a --without-json, otherwise this remains untested and we get back to
the unsatisfactory 'build contents depends on what is on the build
host' situation.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba