[PATCH] s3: Fix the build when compiling without JSON support

Ralph Böhme slow at samba.org
Sun Sep 23 17:07:31 UTC 2018

On Sat, Sep 22, 2018 at 04:26:09PM -0700, Andrew Bartlett wrote:
>On Sun, 2018-09-23 at 09:01 +1000, Martin Schwenke via samba-technical
>> Commit 5534b9248fa375799ad4bc6f45a69dcf14e6419e broke the build when
>> JSON support is not configured.
>> Please review and maybe push...
>> peace & happiness,
>> martin
>Drat.  Given we are now finding more good uses for this encoding, we
>should rename the --without-json-audit parameter to --without-json, fix
>that to control all JSON and adjust the samba-fileserver autobuild
>target to match.  That way we will again have a test for this mode.  (I
>missed that it wasn't controlled properly when I did the review). 
>The alternative would be to require it for any build except --without-
>ads, as we already do for the AD DC.  Certainly we do need a truly
>minimal build, but it is proving a very useful encoding and we might
>want to just bite the bullet. 
>(CC'ing Ralph because we had a great chat this week about the
>implications of the dependency here on packagers). 


For now I'd like to keep json optional.


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list