[PATCH] Some minor clean-ups to confidential attribute fix
abartlet at samba.org
Fri Sep 21 06:05:10 UTC 2018
On Fri, 2018-09-21 at 14:52 +1200, Douglas Bagnall via samba-technical
> On 21/09/18 12:43, Tim Beale via samba-technical wrote:
> > For the changes for bug #13434 (i.e. commit fc45da529dc6794d270), I
> > made
> > a best-guess at some undocumented Microsoft logic. Microsoft has
> > since
> > clarified this logic, so we can now update the code to reflect
> > this.
> > I've also made some minor tweaks to the test code.
> > CI link: https://gitlab.com/catalyst-samba/samba/pipelines/30680063
> > Review appreciated.
> > Thanks.
> RB+, more review needed!
> In the attached version I changed the first one to go on top of my
> recent formatting patches, and I fiddlingly suggest making the known
> attribute name list static. But either way is OK.
Reviewed and pushed.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical