LDB 1.5.0 and 1.5.1 broken

[Andrew Bartlett]

On Fri, 2018-09-21 at 14:34 +1000, Amitay Isaacs via samba-technical
wrote:
> Hi,
> 
> In commit 19be0be232c25250e79dc313fd43829de049b491, a dependency of
> 'ldb_tdb' was added to 'ldb_ldb' module.  That is wrong.  It should
> be
> the library 'ldb_tdb_int'.
> 
> Here is the what you get if you build ldb 1.5.1.
> 
> $ ./configure --prefix=/tmp/ldb-1.5.1
> $ make
> $ make install
> 
> $ ldd /tmp/ldb-1.5.1/modules/ldb/ldb.so
>     linux-vdso.so.1 (0x00007ffe7cda9000)
>     libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fbcef08e000)
>     libldb.so.1 => /tmp/ldb-1.5.1/lib/libldb.so.1
> (0x00007fbceee54000)
>     libldb-key-value.so => /tmp/ldb-1.5.1/lib/ldb/libldb-key-value.so
> (0x00007fbceec3e000)
>     libldb_module_tdb.so => not found
>     libldb-mdb-int.so => /tmp/ldb-1.5.1/lib/ldb/libldb-mdb-int.so
> (0x00007fbceea38000)
>     libtdb.so.1 => /tmp/ldb-1.5.1/lib/ldb/libtdb.so.1
> (0x00007fbcee81d000)
>     libtevent.so.0 => /tmp/ldb-1.5.1/lib/ldb/libtevent.so.0
> (0x00007fbcee606000)
>     libldb-tdb-err-map.so =>
> /tmp/ldb-1.5.1/lib/ldb/libldb-tdb-err-map.so (0x00007fbcee404000)
>     libldb-tdb-int.so => /tmp/ldb-1.5.1/lib/ldb/libldb-tdb-int.so
> (0x00007fbcee1ff000)
>     libtalloc.so.2 => /tmp/ldb-1.5.1/lib/ldb/libtalloc.so.2
> (0x00007fbcedff5000)
>     libbsd.so.0 => /lib64/libbsd.so.0 (0x00007fbcedddf000)
>     libcrypt.so.1 => /lib64/libcrypt.so.1 (0x00007fbcedbb6000)
>     libdl.so.2 => /lib64/libdl.so.2 (0x00007fbced9b2000)
>     liblmdb.so.0.0.0 => /lib64/liblmdb.so.0.0.0 (0x00007fbced79d000)
>     libc.so.6 => /lib64/libc.so.6 (0x00007fbced3de000)
>     /lib64/ld-linux-x86-64.so.2 (0x00007fbcef4af000)
>     librt.so.1 => /lib64/librt.so.1 (0x00007fbced1d6000)
> 
> There is a missing dependency on libldb_module_tdb.so.

Thanks for finding and fixing that.  

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

> What component should I file the ldb bug?

AD: LDB/DSDB/SAMDB

> Amitay.
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba