[PATCH] fix core library string formatting for python 2.6

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Fri Sep 21 01:33:10 UTC 2018


> I will do the tests in another patch.

Here.

Please review with a bit of care: *one* way in which Python's .format()
is inferior to its % printf formatting is there is no error for
unconsumed arguments. That is, if I went:

-    "{} {} {}".format(x, y, z)
+    "{0} {1} {1}".format(x, y, z)

there would be no error to say I had ignored the third argument.
So you need to review my ability to count.

cheers,
Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PATCH-python-tests-fix-format-strings-for-Python-2.6.patch
Type: text/x-patch
Size: 39213 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180921/9d4a15e3/0001-PATCH-python-tests-fix-format-strings-for-Python-2.6.bin>


More information about the samba-technical mailing list