[PATCH] Fix build on RHEL6/Centos6, avoid using python str.format()

[Rowland Penny]

On Thu, 20 Sep 2018 13:06:09 +1200
Douglas Bagnall <douglas.bagnall at catalyst.net.nz> wrote:

> hi Rowland,
> 
> On 19/09/18 21:00, Rowland Penny via samba-technical wrote:
> > 
> > Whilst this will undoubtedly fix the build, it will not help with
> > samba-tool, which is now littered with '[]'
> > 
> > See attached file
> >
> > grep -rnw 'git/samba-master/python/samba/' -e "{}"
> >
> > git/samba-master/python/samba/tests/dns_base.py:213:
> > self.settings = {}
> > git/samba-master/python/samba/tests/source.py:167:        tabs = {}
> > git/samba-master/python/samba/tests/source.py:178:
> > illegal_newlines = {}
> > git/samba-master/python/samba/tests/source.py:188:
> > trailing_whitespace = {}
> > git/samba-master/python/samba/tests/source.py:198:
> > files_with_shebang = {}
> > git/samba-master/python/samba/tests/source.py:199:
> > files_without_shebang = {}
> > git/samba-master/python/samba/tests/kcc/kcc_utils.py:49:
> > self.sites = {}
> > git/samba-master/python/samba/tests/kcc/kcc_utils.py:50:
> > self.site_links = {}
> > git/samba-master/python/samba/tests/kcc/kcc_utils.py:72:        dn
> > = "CN={},CN=Servers,{}".format(name, site)
> > git/samba-master/python/samba/tests/kcc/kcc_utils.py:81:        dn
> > = "CN={},CN=Sites,{}".format(
> 
> Most of those are not format strings (this would get you closer:
> git grep -F '{}' :/*.py | grep format) but yes, there are quite a few
> nonetheless.
> 
> Is nobody using 4.9 on RHEL6?
> 
> Douglas

Its not just RHEL6, see this thread:

https://lists.samba.org/archive/samba/2018-September/218257.html

Rowland