[PATCH] Fix build on RHEL6/Centos6, avoid using python str.format()

Rowland Penny rpenny at samba.org
Wed Sep 19 10:07:03 UTC 2018


On Wed, 19 Sep 2018 19:39:58 +1000
Amitay Isaacs <amitay at gmail.com> wrote:

> On Wed, Sep 19, 2018 at 7:00 PM, Rowland Penny <rpenny at samba.org>
> wrote:
> > On Wed, 19 Sep 2018 18:43:40 +1000
> > Amitay Isaacs via samba-technical <samba-technical at lists.samba.org>
> > wrote:
> >
> >> Hi,
> >>
> >> Small fix to make samba build on RHEL6/Centos6 with python 2.6.
> >>
> >> Please review and push.
> >>
> >> Amitay.
> >
> > Whilst this will undoubtedly fix the build, it will not help with
> > samba-tool, which is now littered with '[]'
> >
> > See attached file
> >
> > Rowland
> 
> I am not building with AD DC.  I am building for clustered samba
> testing.
> 
> May be for AD DC, we need Python > 2.7.0.
> 
> Amitay.

Well, you might not be building for an AD DC, but if you fix this,
someone will, oops sorry, someone already has.

Rowland



More information about the samba-technical mailing list