tdb file corruption when fsync/fdatasync fails

[Jeremy Allison]

On Mon, Sep 17, 2018 at 07:32:20PM +0000, Rungta, Vandana wrote:
> Hello,
> 
> If there is a underlying filesystem glitch/failure when we call smbpasswd  it can result in a corrupted secrets.tdb file.
> 
> Samba – 4.8.4
> smbpasswd -ad <user>   (Called immediately after the samba rpm is installed)
> 
> 
> Aug 29 09:35:02
> 
>  tdb(/usr/local/samba/private/secrets.tdb): tdb_transaction: fsync failed
> 
>   tdb(/usr/local/samba/private/secrets.tdb): tdb_transaction_prepare_commit: failed to setup          recovery data
> 
>   PANIC (pid 11112): could not start commit secrets db
> 
>   BACKTRACE: 7 stack frames:
> 
>    #0 /usr/local/samba/lib/libsamba-util.so.0(log_stack_trace+0x1c) [0x7f9df20f929c]
> 
>    #1 /usr/local/samba/lib/libsmbconf.so.0(smb_panic_s3+0x2d) [0x7f9df1e9075d]
> 
>    #2 /usr/local/samba/lib/libsamba-util.so.0(smb_panic+0x3a) [0x7f9df20f93ca]
> 
>    #3 /usr/local/samba/lib/private/libsecrets3-samba4.so(get_global_sam_sid+0x589) [0x7f9decdb0199]
> 
>    #4 /usr/local/samba/bin/smbpasswd(main+0x60b) [0x5579db0761db]
> 
>    #5 /lib64/libc.so.6(__libc_start_main+0xf5) [0x7f9de50d1445]
> 
>    #6 /usr/local/samba/bin/smbpasswd(+0x3199) [0x5579db075199]
> 
> 
> 
> Aug 29 09:35:02 localhost kernel: [ 4798.314228] EXT4-fs (sda1): Delayed block allocation failed for inode 1323116 at logical offset 4 with max blocks 2 with error 121
> 
> Aug 29 09:35:02 localhost kernel: [ 4798.315778] EXT4-fs (sda1): This should not happen!! Data will be lost

This is a kernel filesystem failure, not a Samba bug.

Sorry, you need to report this to the ext4 maintainers.

Jeremy.