[PATCH] Fix typo setting max protocol

Andrew Bartlett abartlet at samba.org
Tue Sep 11 15:16:35 UTC 2018


On Tue, 2018-09-11 at 16:48 +0200, Michael Adam via samba-technical
wrote:
> On 2018-09-11 at 16:12 +0200, Andreas Schneider wrote:
> > 
> > On Tuesday, 11 September 2018 15:17:04 CEST Michael Adam wrote:
> > > 
> > > On 2018-09-11 at 14:58 +0200, Andreas Schneider via samba-
> > > technical wrote:
> > > > 
> > > > Hi,
> > > > 
> > > > the attached patch fixes a typo setting the max protocol.
> > > > 
> > > > Please review and push if OK.
> > > RB+, obvious goodness.
> > > (I'll allow some more time for others to review.)
> > > 
> > > Gosh, is there a bug for this? :-o
> > I've introduced that function lately and it is only in master!
> Great!
> 
> We need tests...
> I'd love to have the infra to add unit tests for stuff like that.
> 
> Cheers - Michael

Connecting to a server that does and doesn't do SMB2 would seem to be
the trick for that.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list