[PATCH] Fix typo setting max protocol

Michael Adam obnox at samba.org
Tue Sep 11 14:48:29 UTC 2018


On 2018-09-11 at 16:12 +0200, Andreas Schneider wrote:
> On Tuesday, 11 September 2018 15:17:04 CEST Michael Adam wrote:
> > On 2018-09-11 at 14:58 +0200, Andreas Schneider via samba-technical wrote:
> > > Hi,
> > > 
> > > the attached patch fixes a typo setting the max protocol.
> > > 
> > > Please review and push if OK.
> > 
> > RB+, obvious goodness.
> > (I'll allow some more time for others to review.)
> > 
> > Gosh, is there a bug for this? :-o
> 
> I've introduced that function lately and it is only in master!

Great!

We need tests...
I'd love to have the infra to add unit tests for stuff like that.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180911/2202abc7/signature.sig>


More information about the samba-technical mailing list