autobuild and dnspython

[Alexander Bokovoy]

On to, 06 syys 2018, Noel Power via samba-technical wrote:
> Thanks!
> 
> also I did send a patch through yesterday to update the third_party
> version (but it seems to have got stuck in the moderator queue (size?)
> as I don't see it on the list)
> Anyway not sure if is necessary, not sure if opinion is divided,  some
> at atleast seem in favour of dropping it from third_party which imo
> makes sense as there are no real samba specific changes so it seems
> pointless hosting a unpatched upstream copy :-)
We put things into third_party for two reasons:
 - help with environments where these packages might be missing
   completely

 - keep them available at a configuration time 

It is not applied consistently. For example, we require gpgme python
bindings for Samba AD DC build and expect them to be available on the
system. dnspython is a similar case -- it is only used for AD DC build
(in samba_dnsupdate) and for tests that imply use of AD DC build.



> 
> Noel
> On 05/09/18 20:58, Stefan Metzmacher wrote:
> > Am 05.09.2018 um 21:30 schrieb Andrew Bartlett via samba-technical:
> >> On Wed, 2018-09-05 at 19:07 +0100, Noel Power via samba-technical
> >> wrote:
> >>> Hi,
> >>>
> >>> I was trying to push my branch to autobuild, I'm running into a
> >>> problem
> >>> with dnspython [1], it appears we have an intree version in
> >>> third_party
> >>> (that isn't used in gitlab CI) The version is in samba seems woefully
> >>> out of date, what is the procedure here?, do I need to try and port
> >>> the
> >>> failing bits to python3 (and that may not be trivial at all)
> >>>
> >>> I am not aware of the history here but surely this package isn't
> >>> something we need to be hanging on to is it ? do we have some real
> >>> samba
> >>> specific stuff in there. It would be great if the autobuild machine
> >>> could just use system python/python3 dnspython packages and/or drop
> >>> that
> >>> completely from thirdparty (something tells me it's not going to be
> >>> that
> >>> easy :///)
> >> We should simply require it, and drop it from third party. 
> >>
> >> You just need to ask root@ to install it on sn-devel. 
> > I run this:
> >
> > apt-get install python-dnspython python3-dnspython
> >
> > metze
> >
> 
> 

-- 
/ Alexander Bokovoy