[PATCH] samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed (bug 13605)

Andrew Bartlett abartlet at samba.org
Wed Sep 5 19:34:01 UTC 2018


On Wed, 2018-09-05 at 17:12 +0200, Björn Baumbach via samba-technical
wrote:
> Since scavenging is implemented the samba_dnsupdate command always
> updates all dns records required by the dc.
> 
> The attached patch avoids the update if dns zone scavenging is not
> enabled.
> 
> This avoids the repeating TSIG error messages, which fill the samba
> log
> on log level 0:
> 
>  # samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq
> -c
>      29 ; TSIG error with server: tsig verify failure
>       1 Failed update of 29 entries
>  # echo ${PIPESTATUS[0]}
>  29
> 
>  # samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
>  # echo ${PIPESTATUS[0]}
>  0
> 
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605
> 
> Best regards,
> Björn

But why do we get TSIG errors?

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list