autobuild and dnspython

[Alexander Bokovoy]

On ke, 05 syys 2018, Noel Power via samba-technical wrote:
> 
> Hi,
> 
> I was trying to push my branch to autobuild, I'm running into a problem
> with dnspython [1], it appears we have an intree version in third_party
> (that isn't used in gitlab CI) The version is in samba seems woefully
> out of date, what is the procedure here?, do I need to try and port the
> failing bits to python3 (and that may not be trivial at all)
> 
> I am not aware of the history here but surely this package isn't
> something we need to be hanging on to is it ? do we have some real samba
> specific stuff in there. It would be great if the autobuild machine
> could just use system python/python3 dnspython packages and/or drop that
> completely from thirdparty (something tells me it's not going to be that
> easy :///)
We use dnspython in samba_dnsupdate and in traffic simulator. Upstream
dnspython supports py3 (we use it in FreeIPA too). So may be doing a
separate commit to update dnspython version in third_party would be
enough?


> 
> thoughts,
> 
> Noel
> 
> [1]
> 
> [24(179)/36 at 6m4s] samba.tests.emulate.traffic.python3(ad_dc_ntvfs)
> Traceback (most recent call last):
>   File "/memdisk/npower/a/b2097362/samba-py3/source4/scripting/bin/subunitrun", line 87, in <module>
>     TestProgram(module=None, args=args, opts=subunitopts)
>   File "bin/python/samba/tests/subunitrun.py", line 65, in __init__
>     super(TestProgram, self).__init__(module=module, argv=argv)
>   File "bin/python/samba/subunit/run.py", line 542, in __init__
>     self.parseArgs(argv)
>   File "bin/python/samba/subunit/run.py", line 601, in parseArgs
>     self.createTests()
>   File "bin/python/samba/subunit/run.py", line 610, in createTests
>     self.module)
>   File "/usr/lib/python3.4/unittest/loader.py", line 146, in loadTestsFromNames
>     suites = [self.loadTestsFromName(name, module) for name in names]
>   File "/usr/lib/python3.4/unittest/loader.py", line 146, in <listcomp>
>     suites = [self.loadTestsFromName(name, module) for name in names]
>   File "/usr/lib/python3.4/unittest/loader.py", line 105, in loadTestsFromName
>     module = __import__('.'.join(parts_copy))
>   File "bin/python/samba/tests/emulate/traffic.py", line 23, in <module>
>     from samba.emulate import traffic
>   File "bin/python/samba/emulate/traffic.py", line 31, in <module>
>     from samba.emulate import traffic_packets
>   File "bin/python/samba/emulate/traffic_packets.py", line 40, in <module>
>     import dns.resolver
>   File "./third_party/dnspython/dns/resolver.py", line 28, in <module>
>     import dns.message
>   File "./third_party/dnspython/dns/message.py", line 176
>     return '<DNS message, ID ' + `self.id` + '>'
>                                  ^
> 
> 

-- 
/ Alexander Bokovoy