[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

On Wed, Sep 05, 2018 at 12:09:09PM +0300, Alexander Bokovoy via samba-technical wrote:
> On ke, 05 syys 2018, Amitay Isaacs wrote:
> > > Thank you, Andrew, for the reviews and persistent push to complete this!
> > >
> > > We are using WAF 2.x now which should allow us to concentrate on
> > > switching to Python 3 for the build process as well for all our
> > > libraries and components.
> > >
> > > If you see any build issues related to the WAF, please report them.
> > > Autobuild succeeded but we might still have pieces of Python code that
> > > aren't excercised through the autobuild targets.
> > 
> > Great job updating to the latest waf.
> > 
> > Now fixing all the corner cases... ;-)
> :)
> 
> > 
> > On freebsd-11, waf does not want to use clang and complains that it
> > cannot find a C compiler.
> Thanks, I'll do a FreeBSD v11 VM later this week if nobody else gets it
> fixed earlier. The python exception you see is due to this one:
> 
> def CHECK_STANDARD_LIBPATH(conf):
>     # at least gcc and clang support this:
>     try:
>         cmd = conf.env.CC + ['-print-search-dirs']
>         out = Utils.cmd_output(cmd).split('\n')
>     except ValueError:
>         # option not supported by compiler - use a standard list of directories
>         dirlist = [ '/usr/lib', '/usr/lib64' ]
>     except:
>         raise Errors.WafError('Unexpected error running "%s"' % (cmd))
>     .....
> 
> we don't even have conf.env.CC set and get an exception while
> defining 'cmd' value, thus it is not defined when the latter except:
> statement runs.
> 
> I'll look at it.

Alexander,

I just want to say *THANKS* for all the work you put into
this. Dealing with waf is not a trivial problem :-).

Cheers,

	Jeremy.