[PATCH] samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed (bug 13605)

Björn Baumbach bb at sernet.de
Wed Sep 5 15:12:00 UTC 2018

Since scavenging is implemented the samba_dnsupdate command always
updates all dns records required by the dc.

The attached patch avoids the update if dns zone scavenging is not enabled.

This avoids the repeating TSIG error messages, which fill the samba log
on log level 0:

 # samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq -c
     29 ; TSIG error with server: tsig verify failure
      1 Failed update of 29 entries
 # echo ${PIPESTATUS[0]}

 # samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
 # echo ${PIPESTATUS[0]}

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605

Best regards,

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba_dnsupdate-honor-dns-zone-scavenging-option-onl.patch
Type: text/x-patch
Size: 1927 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180905/d6a3e3db/0001-samba_dnsupdate-honor-dns-zone-scavenging-option-onl.bin>

More information about the samba-technical mailing list