dbwrap_tool: Simplify persistent/non-persistent check / dbwrap_tool: Avoid an unnecessary "else"

Andrew Bartlett abartlet at samba.org
Tue Sep 4 09:07:30 UTC 2018

On Tue, 2018-09-04 at 10:53 +0200, Volker Lendecke wrote:
> On Tue, Sep 04, 2018 at 10:49:40AM +0200, Ralph Böhme wrote:
> > 
> > On Tue, Sep 04, 2018 at 10:33:16AM +0200, Volker Lendecke wrote:
> > > 
> > > Enough is enough. Sorry for the trouble this caused.
> > > 
> > > Review appreciated!
> > can we please not revert this and keep the improved code? At least
> > three of
> > us (Jeremey, you, me) agree that the patches are an improvement.
> Please revert this. It caused a discussion that is really not worth
> it. My life does not depend on such controversial patches, and it is
> better to bury it sooner rather than later if it offends people so
> much. The former code worked and was much cleaner to many people, so
> it's better to restore the non-controversial state than to keep
> people
> upset.

G'Day Volker,

Please be willing to accept comment on your code, especially wrong,
opinionated and ill-considered comment.  

The alternative is worse, I assure you.  I sit next to Gary, who seems
to have discovered the Samba cone of silence!

In the meantime, the bike shed should be blue, and perhaps this can
settle it:


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list