Trust related bugfixes (bug #11517, bug #13539)

Alexander Bokovoy ab at samba.org
Tue Sep 4 05:03:24 UTC 2018


On ti, 04 syys 2018, Andrew Bartlett via samba-technical wrote:
> On Mon, 2018-09-03 at 14:11 +0200, Stefan Metzmacher via samba-
> technical wrote:
> > ... and here are the patches...
> > 
> > Am 03.09.2018 um 14:09 schrieb Stefan Metzmacher via samba-technical:
> > > Hi,
> > > 
> > > here're some fixes for trust setups:
> > > 
> > > https://bugzilla.samba.org/show_bug.cgi?id=11517
> > > Samba GPO issue when Trust is enabled
> > > 
> > > https://bugzilla.samba.org/show_bug.cgi?id=13539
> > > Samba generates the wrong salt for the trusted domain user account
> > > 
> > > Here's the (just started) pipeline:
> > > https://gitlab.com/samba-team/devel/samba/pipelines/29275981
> > > 
> > > Please review and push.
> > > 
> > > Thanks!
> > > metze
> > > 
> > > 
> 
> Thanks.  However there is a problem.  I dropped the first patch and ran
> 'make test TESTS=trusts' and all the tests still pass, so we don't
> actually have a test to show this change is correct.
Yes, this is what I described in the original discussion here too -- we
test against patched version of Samba so it does not exhibit difference
in salt behavior. Metze wanted to have a number of tests for that as
outlined in https://bugzilla.samba.org/show_bug.cgi?id=13539

> 
> Thinking about this, the test needs to manually create the secret from
> a salt, and then compare with the output of a remote password set and
> GetNCChanges call.
> 
> I'll see if I can merge the other patches however.
> 
> Also, Alexander's first patch is still TODO: on the Signed-off-by.
It looks fine, close to my original patch, so TODO should be removed.

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list