dbwrap_tool: Simplify persistent/non-persistent check / dbwrap_tool: Avoid an unnecessary "else"

Andrew Bartlett abartlet at samba.org
Tue Sep 4 03:49:20 UTC 2018

On Tue, 2018-09-04 at 05:33 +0200, Volker Lendecke via samba-technical
> On Tue, Sep 04, 2018 at 09:11:32AM +1200, Andrew Bartlett via samba-technical wrote:
> > 
> > What specifically was the goal of the change here?
> Whenever I see an "else" with a "return" right before, the "else" is
> redundant. The "else" makes me go back to the "if-condition" and see
> what it was. Without the "else" this special condition is just done
> and out of my mind. Easier flow to read for me.

Thanks, that makes more sense now.

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list