Trust related bugfixes (bug #11517, bug #13539)

[Andrew Bartlett]

On Tue, 2018-09-04 at 10:53 +1200, Andrew Bartlett wrote:
> On Mon, 2018-09-03 at 14:11 +0200, Stefan Metzmacher via samba-
> technical wrote:
> > ... and here are the patches...
> > 
> > Am 03.09.2018 um 14:09 schrieb Stefan Metzmacher via samba-technical:
> > > Hi,
> > > 
> > > here're some fixes for trust setups:
> > > 
> > > https://bugzilla.samba.org/show_bug.cgi?id=11517
> > > Samba GPO issue when Trust is enabled
> > > 
> > > https://bugzilla.samba.org/show_bug.cgi?id=13539
> > > Samba generates the wrong salt for the trusted domain user account
> > > 
> > > Here's the (just started) pipeline:
> > > https://gitlab.com/samba-team/devel/samba/pipelines/29275981
> > > 
> > > Please review and push.
> > > 
> > > Thanks!
> > > metze
> > > 
> > > 
> 
> Thanks.  However there is a problem.  I dropped the first patch and ran
> 'make test TESTS=trusts' and all the tests still pass, so we don't
> actually have a test to show this change is correct.
> 
> Thinking about this, the test needs to manually create the secret from
> a salt, and then compare with the output of a remote password set and
> GetNCChanges call.
> 
> I'll see if I can merge the other patches however.

The patches that were OK (ie, all but the first two) landed as 
2099add0657126e4a5427ec2db0fe8025478b355 today.

> Also, Alexander's first patch is still TODO: on the Signed-off-by.
> 
> Sorry,
> 
> Andrew Bartlett
> 
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba